Skip to content

Conversation

@shiltian
Copy link
Contributor

@shiltian shiltian commented Dec 2, 2024

The compile command for the two C test files are compilexx, which is actually
for C++ compilation.

The compile command for the two C test files are `compilexx`, which is actually
for C++ compilation.
@llvmbot llvmbot added the offload label Dec 2, 2024
Copy link
Contributor Author

shiltian commented Dec 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@llvmbot
Copy link
Member

llvmbot commented Dec 2, 2024

@llvm/pr-subscribers-offload

Author: Shilei Tian (shiltian)

Changes

The compile command for the two C test files are compilexx, which is actually
for C++ compilation.


Full diff: https://github.com/llvm/llvm-project/pull/118243.diff

2 Files Affected:

  • (modified) offload/test/mapping/map_both_pointer_pointee.c (+5-5)
  • (modified) offload/test/mapping/power_of_two_alignment.c (+1-1)
diff --git a/offload/test/mapping/map_both_pointer_pointee.c b/offload/test/mapping/map_both_pointer_pointee.c
index c4894ed97af577..7be1ba465e7db5 100644
--- a/offload/test/mapping/map_both_pointer_pointee.c
+++ b/offload/test/mapping/map_both_pointer_pointee.c
@@ -1,8 +1,8 @@
-// RUN: %libomptarget-compilexx-run-and-check-aarch64-unknown-linux-gnu
-// RUN: %libomptarget-compilexx-run-and-check-powerpc64-ibm-linux-gnu
-// RUN: %libomptarget-compilexx-run-and-check-powerpc64le-ibm-linux-gnu
-// RUN: %libomptarget-compilexx-run-and-check-x86_64-unknown-linux-gnu
-// RUN: %libomptarget-compilexx-run-and-check-nvptx64-nvidia-cuda
+// RUN: %libomptarget-compile-run-and-check-aarch64-unknown-linux-gnu
+// RUN: %libomptarget-compile-run-and-check-powerpc64-ibm-linux-gnu
+// RUN: %libomptarget-compile-run-and-check-powerpc64le-ibm-linux-gnu
+// RUN: %libomptarget-compile-run-and-check-x86_64-unknown-linux-gnu
+// RUN: %libomptarget-compile-run-and-check-nvptx64-nvidia-cuda
 
 // REQUIRES: unified_shared_memory
 // UNSUPPORTED: amdgcn-amd-amdhsa
diff --git a/offload/test/mapping/power_of_two_alignment.c b/offload/test/mapping/power_of_two_alignment.c
index faebe4f89fd9d8..0a457f97e16f5a 100644
--- a/offload/test/mapping/power_of_two_alignment.c
+++ b/offload/test/mapping/power_of_two_alignment.c
@@ -1,4 +1,4 @@
-// RUN: %libomptarget-compilexx-run-and-check-generic
+// RUN: %libomptarget-compile-run-and-check-generic
 
 // Assuming the stack is allocated on the host starting at high addresses, the
 // host memory layout for the following program looks like this:

@shiltian shiltian merged commit ed7a8f1 into main Dec 2, 2024
8 checks passed
@shiltian shiltian deleted the users/shiltian/correct-compile-command branch December 2, 2024 02:34
@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 2, 2024

LLVM Buildbot has detected a new failure on builder openmp-offload-amdgpu-runtime running on omp-vega20-0 while building offload at step 7 "Add check check-offload".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/11311

Here is the relevant piece of the build log for the reference
Step 7 (Add check check-offload) failure: test (failure)
******************** TEST 'libomptarget :: amdgcn-amd-amdhsa :: mapping/power_of_two_alignment.c' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/./bin/clang -fopenmp    -I /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test -I /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -L /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/./lib -L /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src  -nogpulib -Wl,-rpath,/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -Wl,-rpath,/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/./lib  -fopenmp-targets=amdgcn-amd-amdhsa /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c -o /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload/test/amdgcn-amd-amdhsa/mapping/Output/power_of_two_alignment.c.tmp /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/./lib/libomptarget.devicertl.a && /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload/test/amdgcn-amd-amdhsa/mapping/Output/power_of_two_alignment.c.tmp | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/./bin/FileCheck /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c
# executed command: /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/./bin/clang -fopenmp -I /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test -I /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -L /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/./lib -L /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -nogpulib -Wl,-rpath,/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload -Wl,-rpath,/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/./lib -fopenmp-targets=amdgcn-amd-amdhsa /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c -o /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/offload/test/amdgcn-amd-amdhsa/mapping/Output/power_of_two_alignment.c.tmp /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/./lib/libomptarget.devicertl.a
# .---command stderr------------
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:45:1: error: unknown type name 'template'
# |    45 | template <typename StackPad>
# |       | ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:45:10: error: expected identifier or '('
# |    45 | template <typename StackPad>
# |       |          ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:70:3: error: use of undeclared identifier 'test'
# |    70 |   TEST(char[1]);
# |       |   ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:67:3: note: expanded from macro 'TEST'
# |    67 |   test<StackPad>()
# |       |   ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:70:8: error: expected expression
# |    70 |   TEST(char[1]);
# |       |        ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:71:3: error: use of undeclared identifier 'test'
# |    71 |   TEST(char[2]);
# |       |   ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:67:3: note: expanded from macro 'TEST'
# |    67 |   test<StackPad>()
# |       |   ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:71:8: error: expected expression
# |    71 |   TEST(char[2]);
# |       |        ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:72:3: error: use of undeclared identifier 'test'
# |    72 |   TEST(char[3]);
# |       |   ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:67:3: note: expanded from macro 'TEST'
# |    67 |   test<StackPad>()
# |       |   ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:72:8: error: expected expression
# |    72 |   TEST(char[3]);
# |       |        ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:73:3: error: use of undeclared identifier 'test'
# |    73 |   TEST(char[4]);
# |       |   ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:67:3: note: expanded from macro 'TEST'
# |    67 |   test<StackPad>()
# |       |   ^
# | /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/offload/test/mapping/power_of_two_alignment.c:73:8: error: expected expression
# |    73 |   TEST(char[4]);
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants